Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kde-frameworks: 5.38 -> 5.39 #30573

Merged
merged 5 commits into from Oct 28, 2017
Merged

kde-frameworks: 5.38 -> 5.39 #30573

merged 5 commits into from Oct 28, 2017

Conversation

peterhoeg
Copy link
Member

Motivation for this change

Regular scheduled update. Haven't built everything yet as I need to try that out on a desktop instead of the anemic laptop.

Cc: @adisbladis @ttuegel

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@FRidh FRidh requested a review from ttuegel October 19, 2017 12:58
@ttuegel
Copy link
Member

ttuegel commented Oct 19, 2017

Just off the top of my head, we also need to cherry-pick this commit:
https://cgit.kde.org/ktexteditor.git/commit/?id=aeebeadb5f5955995c17de56cf83ba7166a132dd

@adisbladis
Copy link
Member

@peterhoeg I actually started on this before you made the PR :) Have been running on frameworks 5.39 without any hiccups for the last few days.

@adisbladis
Copy link
Member

@peterhoeg I saw that you added digikam-5.7.0, this was already merged in master (27b7192).

@peterhoeg
Copy link
Member Author

Running nox-review wip so I should know more in a few hours. Thanks for your feedback @adisbladis and @ttuegel .

@peti peti removed their request for review October 23, 2017 17:54
@peterhoeg
Copy link
Member Author

Have been running on frameworks 5.39 without any hiccups for the last few days.

digikam keeps failing when I run nox-review wip complaining about a missing gitversion.h. Did you experience that @adisbladis ?

@bkchr
Copy link
Contributor

bkchr commented Oct 27, 2017

@peterhoeg do you still have these problems? I tried nix-build -A digikam with your commits and that worked for me.

@FRidh FRidh removed their request for review October 27, 2017 15:11
@peterhoeg
Copy link
Member Author

It's ok now, so I'm merging this. Thanks @bkchr

@peterhoeg peterhoeg merged commit 405f905 into NixOS:master Oct 28, 2017
@peterhoeg peterhoeg deleted the u/kf5 branch October 28, 2017 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel ttuegel is a code owner

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
6.topic: qt/kde
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@peterhoeg @ttuegel @adisbladis @bkchr @FRidh