Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

texlive: fix after dependency update #30564

Merged
merged 1 commit into from Oct 19, 2017
Merged

texlive: fix after dependency update #30564

merged 1 commit into from Oct 19, 2017

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Oct 19, 2017 •
edited

Motivation for this change

Fixes #30488
The breakage of texlive.bin.core-big was limited to macOS:
https://hydra.nixos.org/build/62492479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@veprbl
Copy link
Member Author

veprbl commented Oct 19, 2017 •
edited

cc @vcunat @lovek323 @raskin @jwiegley

@LnL7 LnL7 merged commit 7771edb into NixOS:master Oct 19, 2017
@LnL7 LnL7 added the 6.topic: darwin Running or building packages on Darwin label Oct 19, 2017
@vcunat
Copy link
Member

vcunat commented Oct 20, 2017

Ah, right; I suppose adding -std=c++11 is unlikely to break anything even without checking the code...

@veprbl veprbl deleted the texlive-icu-fix branch December 1, 2020 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@veprbl @vcunat @LnL7