Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.python-fontconfig: init at 0.5.1 #30576

Closed
wants to merge 5 commits into from
Closed

pythonPackages.python-fontconfig: init at 0.5.1 #30576

wants to merge 5 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 19, 2017

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@ghost ghost requested a review from FRidh as a code owner October 19, 2017 10:34
FRidh
FRidh requested changes Oct 19, 2017
View reviewed changes
pkgs/top-level/python-packages.nix Outdated
@@ -5538,6 +5538,24 @@ in {
};
};

fontconfig = buildPythonPackage rec {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the header of this file; the expression needs to be moved.

pkgs/top-level/python-packages.nix Outdated
fontconfig = buildPythonPackage rec {
name = "Python-fontconfig-0.5.1";

src = pkgs.fetchurl {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fetchPypi

@FRidh FRidh self-assigned this Oct 19, 2017
@FRidh FRidh removed their assignment Oct 19, 2017
@FRidh
Copy link
Member

FRidh commented Oct 19, 2017 

Ran 0 tests in 0.000s

No tests are found. Either the test runner cannot find tests and needs to be patched, or there simply are no tests in which case the tests need to be disabled. Do include a comment explaining why the tests are disabled.

@ghost
Copy link
Author

ghost commented Oct 19, 2017

@FRidh I've added the test, but it fails under chroot with Fontconfig error: Cannot load default config file

@ghost ghost changed the title pythonPackages.fontconfig: init at 0.5.1 pythonPackages.python-fontconfig: init at 0.5.1 Oct 19, 2017
@FRidh
Copy link
Member

FRidh commented Oct 19, 2017 •
edited

You can set up a cache with

    fontsConf = pkgs.makeFontsCache {
      fontDirectories = [
        "${pkgs.ghostscript}/share/ghostscript/fonts"
      ];
    };

and

export FONTCONFIG_FILE=${fontsConf}

or just disable the test.

@ghost
Copy link
Author

ghost commented Oct 19, 2017

@FRidh It works, thank you!

@FRidh
Copy link
Member

FRidh commented Oct 19, 2017

Good. Pushed b17ec54.

@FRidh FRidh closed this Oct 19, 2017
@ghost ghost deleted the fontconfig branch October 19, 2017 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@FRidh