Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scons: 2.5.1 -> 3.0.0 #30580

Merged
merged 1 commit into from Oct 20, 2017
Merged

scons: 2.5.1 -> 3.0.0 #30580

merged 1 commit into from Oct 20, 2017

Conversation

primeos
Copy link
Member

@primeos primeos commented Oct 19, 2017

Causes 481 rebuilds (currently testing some of them).


"SCons release 3.0.0 now available from the download page at
SourceForge. This release should be used instead of 2.5.1. This release
fixes several issues. TThis will be the first release to support Python
versions earlier than 2.7 as well as 3.5+."

"NOTE: This is a major release. You should expect that some targets may
rebuild when upgrading. Significant changes in some python action
signatures. Also switching between PY 2.7 and PY 3.5, 3.6 will cause
rebuilds."

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Oct 19, 2017

Can you build all packages that depend on scons?

@primeos
Copy link
Member Author

primeos commented Oct 19, 2017

@FRidh Not sure yet, but I'm currently trying to rebuild as many as possible on my server.

"SCons release 3.0.0 now available from the download page at
SourceForge. This release should be used instead of 2.5.1. This release
fixes several issues.  TThis will be the first release to support Python
versions earlier than 2.7 as well as 3.5+."

"NOTE: This is a major release.  You should expect that some targets may
rebuild when upgrading.  Significant changes in some python action
signatures. Also switching between PY 2.7 and PY 3.5, 3.6 will cause
rebuilds."
@primeos
Copy link
Member Author

primeos commented Oct 20, 2017

The upgrade shouldn't cause any build failures, but due to some unrelated failures and packages that were broken before the upgrade (10 packages in my case - I was a bit behind master) I couldn't verify everything.

But IMO this shouldn't cause any regressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants