dump1090: init at bff92c4 #30559
dump1090: init at bff92c4 #30559
Conversation
|
|
| meta = with stdenv.lib; { | ||
| description = "A simple Mode S decoder for RTLSDR devices"; | ||
| homepage = https://github.com/MalcolmRobb/dump1090; | ||
| license = licenses.bsd3; |
There was a problem hiding this comment.
There was a problem hiding this comment.
Oh my bad at the bottom of the readme it says it's released as bsd3. 🤷♀️
| { stdenv, fetchgit, gnumake, pkgconfig, libusb, rtl-sdr }: | ||
|
|
||
| stdenv.mkDerivation rec { | ||
| name = "dump1090"; |
There was a problem hiding this comment.
You should set a version like "dump1090-<version>", so in this case a date for when the commit was made should be the version: "dump1090-2014-11-01".
| stdenv.mkDerivation rec { | ||
| name = "dump1090"; | ||
|
|
||
| src = fetchgit { |
| homepage = https://github.com/MalcolmRobb/dump1090; | ||
| license = licenses.bsd3; | ||
| platforms = platforms.linux; | ||
| }; |
There was a problem hiding this comment.
Is this the maintainer of dump1090 itself, or is this the maintainer of the dump1090 package derivation?
There was a problem hiding this comment.
Maintainer of the derivation/nix expression.
|
@vyp: Thanks for the feedback. I have incorporated your recommendations. |
| }; | ||
|
|
||
| nativeBuildInputs = [ pkgconfig ]; | ||
| buildInputs = [ gnumake libusb rtl-sdr ]; |
There was a problem hiding this comment.
I take it that the output captures a reference to make that it wants to execute at runtime? Otherwise it's better to rely on gnumake being part of the standard build env.
There was a problem hiding this comment.
Ah, good point. I have dropped gnumake and updated the PR.
|
@GrahamcOfBorg dump1090 |
There was a problem hiding this comment.
'public_html/gmap.html' -> '/nix/store/mx17apkwjw86khs8na99wvzhcn4i4aks-dump1090-2014-10-31/share/dump1090/gmap.html'
'public_html/options.js' -> '/nix/store/mx17apkwjw86khs8na99wvzhcn4i4aks-dump1090-2014-10-31/share/dump1090/options.js'
'public_html/planeObject.js' -> '/nix/store/mx17apkwjw86khs8na99wvzhcn4i4aks-dump1090-2014-10-31/share/dump1090/planeObject.js'
'public_html/script.js' -> '/nix/store/mx17apkwjw86khs8na99wvzhcn4i4aks-dump1090-2014-10-31/share/dump1090/script.js'
'public_html/style.css' -> '/nix/store/mx17apkwjw86khs8na99wvzhcn4i4aks-dump1090-2014-10-31/share/dump1090/style.css'
'public_html/coolclock' -> '/nix/store/mx17apkwjw86khs8na99wvzhcn4i4aks-dump1090-2014-10-31/share/dump1090/coolclock'
'public_html/coolclock/coolclock.js' -> '/nix/store/mx17apkwjw86khs8na99wvzhcn4i4aks-dump1090-2014-10-31/share/dump1090/coolclock/coolclock.js'
'public_html/coolclock/excanvas.js' -> '/nix/store/mx17apkwjw86khs8na99wvzhcn4i4aks-dump1090-2014-10-31/share/dump1090/coolclock/excanvas.js'
'public_html/coolclock/moreskins.js' -> '/nix/store/mx17apkwjw86khs8na99wvzhcn4i4aks-dump1090-2014-10-31/share/dump1090/coolclock/moreskins.js'
/nix/store/mx17apkwjw86khs8na99wvzhcn4i4aks-dump1090-2014-10-31
Motivation for this change
Allow nix users to easily install dump1090.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)