Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.phonenumbers: 8.8.2 -> 8.8.4 #30574

Merged
merged 1 commit into from Oct 22, 2017
Merged

pythonPackages.phonenumbers: 8.8.2 -> 8.8.4 #30574

merged 1 commit into from Oct 22, 2017

Conversation

fadenb
Copy link
Contributor

@fadenb fadenb commented Oct 19, 2017

Motivation for this change

Update available

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Oct 19, 2017

can you move this expression

@globin globin merged commit 5c779de into NixOS:master Oct 22, 2017
@globin
Copy link
Member

globin commented Oct 22, 2017

Merged as it was in the python-modules folder already

@fadenb fadenb deleted the phonenumbers-8.8.4 branch March 28, 2018 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fadenb @FRidh @globin