Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yarn: 1.0.1 -> 1.2.1 #30578

Closed
wants to merge 1 commit into from
Closed

yarn: 1.0.1 -> 1.2.1 #30578

wants to merge 1 commit into from

Conversation

vidbina
Copy link
Contributor

@vidbina vidbina commented Oct 19, 2017

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@rycee
Copy link
Member

rycee commented Oct 19, 2017

As far as I can tell yarn is already at 1.2.1 in master. Is the changed node parameter necessary for 1.2.1?

@vidbina
Copy link
Contributor Author

vidbina commented Oct 20, 2017 via email

@rycee
Copy link
Member

rycee commented Oct 20, 2017

Ok no problems, I'll close this PR :-)

@rycee rycee closed this Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vidbina @rycee