Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlPackages.csv: Fix source URL #30570

Merged
merged 1 commit into from Nov 1, 2017
Merged

Conversation

ibor
Copy link
Contributor

@ibor ibor commented Oct 19, 2017

(upstream migrated to GitHub)

See #30476

(upstream migrated to GitHub)
@Mic92 Mic92 added 9.needs: port to stable A PR needs a backport to the stable release. 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Oct 19, 2017
@vbgl
Copy link
Contributor

vbgl commented Oct 19, 2017

Why not just cherry-pick 1e9deaa?

@ibor
Copy link
Contributor Author

ibor commented Oct 25, 2017

Bumping to 2.0 was the original idea in #30476. However I got the impression that a minimal fix might be more appreciated. Is there anything arguing against just (quickly) fixing the URL?

@vbgl
Copy link
Contributor

vbgl commented Oct 25, 2017

If this were just a quick fix of the URL, there would not be a hash change.

@ibor
Copy link
Contributor Author

ibor commented Oct 25, 2017

That's correct. The tarball was re-generated on github by the original author (Chris00/ocaml-csv#20). I have no idea why the hash changed, and I cannot check without access to the original file.

However, why would your use the 2.0 tarball but not trust the 1.7 tarball? Both are available from the same location, and both were apparently generated by the same person.

@vbgl
Copy link
Contributor

vbgl commented Oct 31, 2017

I trust both tarballs equally: can you please elaborate on the tests you’ve performed?

@ibor
Copy link
Contributor Author

ibor commented Nov 1, 2017

@vbgl: Nothing special.
My local nix-based build succeeded, apparently passed the package's unit tests, and installed.
Same here: https://travis-ci.org/NixOS/nixpkgs/jobs/289842399

@vbgl vbgl merged commit e336363 into NixOS:release-17.09 Nov 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: port to stable A PR already has a backport to the stable release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants