fetchgitrev: fix parsing and add certs for https://github.com fetching #30569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the cert is not provided, the git operation for an https repository (e.g. https://github.com) will fail with an SSL error because the local signatures are not available.
The git ls-remote command will return results like: somelonghash refs/heads/branch1 another_hash refs/heads/master another1hash refs/tags/4.1.3 another2hash refs/tags/4.1.0 The parsing of the response now accomodates any interim reference identifier, enabling fetchgitrevision to work for both branches and tags, whereas previously it would never match anything for modern github responses (although the old matching behavior is preserved in case older github was less specific in the ls-remote response).
kquick
changed the title
bjornfor
approved these changes
Oct 19, 2017
matthewbauer
requested changes
Apr 21, 2018
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fix fetchgitrevision to work properly. There appear to be no current uses of this in the nixpkgs repo, but attempts to use it locally failed until the patches in this PR were applied.
Things done
build-use-sandboxinnix.confon non-NixOS)Note this was tested without using sandbox: when sandboxing is enabled, uses of fetchgitrevision fail with a DNS lookup error for github.com. I believe this is a side-effect of sandboxing and unrelated to the changes here.
nix-shell -p nox --run "nox-review wip"./result/bin/)