Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildNodePackage: Fix impure packages patching #30577

Merged
merged 1 commit into from Oct 22, 2017

Conversation

b123400
Copy link
Contributor

@b123400 b123400 commented Oct 19, 2017

Motivation for this change

buildNodePackage replaces impure version specs in package.json before npm install.

It currently changes package like these:

{
  "dependencies": {
    "package1":"latest"
  }
}

To:

{
  "dependencies": {
    "package1":"*"
  }
}

such that packages fetched by nix is used, pureness is maintained.

However it does not handle the case of empty version string (""), which is same as "latest".

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@globin globin merged commit 2cc79e9 into NixOS:master Oct 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants