Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yarn: 1.0.1 -> 1.2.0 #30346

Merged
merged 1 commit into from Oct 13, 2017
Merged

yarn: 1.0.1 -> 1.2.0 #30346

merged 1 commit into from Oct 13, 2017

Conversation

frontsideair
Copy link
Contributor

@frontsideair frontsideair commented Oct 12, 2017 •
edited by zimbatm

Motivation for this change

Upstream release

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 requested a review from zimbatm October 12, 2017 14:05
@zimbatm
Copy link
Member

zimbatm commented Oct 12, 2017 •
edited

@frontsideair 1.2.1 just got released 4 hours ago. mind updating the PR? (it includes a bunch of bugfixes)

@frontsideair
Copy link
Contributor Author

frontsideair commented Oct 12, 2017 via email

@frontsideair
Copy link
Contributor Author

@zimbatm guess it's ready.

@jb55
Copy link
Contributor

jb55 commented Oct 13, 2017

nit: I see two commits. rebase perhaps?

@frontsideair
Copy link
Contributor Author

Done, thanks for feedback!

@zimbatm zimbatm merged commit 826d7d2 into NixOS:master Oct 13, 2017
@zimbatm
Copy link
Member

zimbatm commented Oct 13, 2017

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@frontsideair @zimbatm @jb55