Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sddm-kcm: init at 5.10.5 #30354

Merged
merged 1 commit into from Oct 13, 2017
Merged

sddm-kcm: init at 5.10.5 #30354

merged 1 commit into from Oct 13, 2017

Conversation

peterhoeg
Copy link
Member

Motivation for this change

I wanted to see if a custom theme was being detected properly, so I packaged this. It is however for all other purposes completely pointless as it tries to change /etc/sddm.conf which is obviously read-only.

@ttuegel - what do you think? Merge or throw away?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Oct 12, 2017

as it tries to change /etc/sddm.conf which is obviously read-only.

Its not implemented in such a way that it detects its read-only and just greys out all options?

@ttuegel
Copy link
Member

ttuegel commented Oct 12, 2017

Its not implemented in such a way that it detects its read-only and just greys out all options?

This is KDE.
"Why would you check for a condition that is obviously true?"

No sense in throwing it away. SDDM is terribly difficult to debug. Anything that makes that easier is good in my book.

@peterhoeg peterhoeg merged commit 82b8a22 into NixOS:master Oct 13, 2017
@peterhoeg peterhoeg deleted the p/sddm-kcm branch October 13, 2017 01:52
@peterhoeg peterhoeg restored the p/sddm-kcm branch October 14, 2017 05:58
@peterhoeg peterhoeg deleted the p/sddm-kcm branch October 14, 2017 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peterhoeg @FRidh @ttuegel