Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/jenkins: add an option for the package #30588

Closed
wants to merge 1 commit into from
Closed

nixos/jenkins: add an option for the package #30588

wants to merge 1 commit into from

Conversation

earldouglas
Copy link
Member

This allows NixOS configuration to specify the desired Jenkins package.

Motivation for this change

Jenkins releases new versions frequently, often for security fixes, and it's not feasible for nixpkgs to always keep up. This change allows users to use any version they like, even if it's ahead of what's in the channel.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

This allows NixOS configuration to specify the desired Jenkins package.
@NeQuissimus NeQuissimus self-requested a review October 19, 2017 18:40
@rycee
Copy link
Member

rycee commented Oct 19, 2017

Good idea! Rebased to master in aae32e1. Thanks for reviewing @NeQuissimus :-)

@rycee rycee closed this Oct 19, 2017
@earldouglas earldouglas mentioned this pull request Feb 14, 2018
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants