Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

musl: 1.1.16 -> 1.1.17, build with stack protector #30591

Merged
merged 1 commit into from Oct 20, 2017
Merged

musl: 1.1.16 -> 1.1.17, build with stack protector #30591

merged 1 commit into from Oct 20, 2017

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Oct 19, 2017

Motivation for this change

Release notes:
http://www.openwall.com/lists/musl/2017/10/19/1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member Author

dtzWill commented Oct 19, 2017

Tested bootstrap-tools with:

$ nix-build pkgs/stdenv/linux/make-bootstrap-tools.nix -A test

since musl is used there.

@fpletz fpletz merged commit 48553c3 into NixOS:master Oct 20, 2017
@dtzWill dtzWill deleted the update/musl-1.1.17 branch October 29, 2017 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @fpletz