Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jenkins: 2.84 -> 2.85 #30583

Merged
merged 1 commit into from Oct 19, 2017
Merged

jenkins: 2.84 -> 2.85 #30583

merged 1 commit into from Oct 19, 2017

Conversation

earldouglas
Copy link
Member

@earldouglas earldouglas commented Oct 19, 2017 •
edited

Motivation for this change

Get rid of the nag message in Jenkins about downloading the latest jenkins.war file.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@NeQuissimus NeQuissimus merged commit 9d82aa6 into NixOS:master Oct 19, 2017
@NeQuissimus
Copy link
Member

I picked this into 17.09 and ran the test there, everything looks good

@earldouglas earldouglas deleted the jenkins-2.85 branch October 19, 2017 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@earldouglas @NeQuissimus