Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

radiotray-ng: init at 0.1.7 #30105

Merged
merged 1 commit into from Oct 7, 2017
Merged

radiotray-ng: init at 0.1.7 #30105

merged 1 commit into from Oct 7, 2017

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Oct 5, 2017

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Includes update for libxdg_basedir (#30104), since without it the program crashes on startup.

@disassembler
Copy link
Member

looks good to me

jtojnar
jtojnar approved these changes Oct 5, 2017
View reviewed changes
pkgs/applications/audio/radiotray-ng/default.nix Outdated
checkPhase = "ctest";

preFixup = ''
gappsWrapperArgs+=(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following two lines are already part of wrapGAppsHook.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I meant to request changes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, thanks! Updated to remove the redundant bits.

@jtojnar
Copy link
Contributor

jtojnar commented Oct 6, 2017 •
edited

The app crashes for me when I select a radio station in the menu

$ result/bin/radiotray-ng 

(radiotray-ng:3952): Gdk-CRITICAL **: gdk_window_thaw_toplevel_updates: assertion 'window->update_and_descendants_freeze_count > 0' failed

(radiotray-ng:3952): GLib-GIO-ERROR **: Settings schema 'org.gnome.system.proxy' is not installed

fish: “result/bin/radiotray-ng” terminated by signal SIGTRAP (Trace or breakpoint trap)

The derivation should probably depend on gsettings_desktop_schemas.

@dtzWill
radiotray-ng: init at 0.1.7
b82fbee 
Use patch from upstream to fix menu separators.

Tested execution using
'nix-shell --pure -p radiotray-ng'
and added dependencies until that didn't crash.

Seems to work outside as well,
but hopefully fixes problems for others.
@dtzWill
Copy link
Member Author

dtzWill commented Oct 6, 2017

The app crashes for me when I select a radio station in the menu

Added gsettings_desktop_schemas as suggested, also chase down deps until it didn't crash in nix-shell --pure.

Would you mind trying again to see if it works now?

@jtojnar
Copy link
Contributor

jtojnar commented Oct 6, 2017

Works fine now. The bookmark editor menu item is insensitive but according to the source code it is intentional.

@Mic92 Mic92 merged commit 938d4f6 into NixOS:master Oct 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @disassembler @jtojnar @Mic92