declarative containers: improve example config #30107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Container config example code mentions `postgresql` service, but the correct use of that service involves setting `system.stateVersion` option (as discovered in NixOS#30056). The actual system state version is set randomly to 17.03 because I have no preferences here
orivej
approved these changes
Oct 5, 2017
rycee
reviewed
Nov 1, 2017
| @@ -596,6 +596,8 @@ in | |||
| { config, pkgs, ... }: | |||
| { services.postgresql.enable = true; | |||
| services.postgresql.package = pkgs.postgresql96; | |||
|
|
|||
| system.stateVersion = "17.03"; | |||
There was a problem hiding this comment.
Perhaps could try having system.stateVersion = "${config.system.nixosRelease}"; here? My idea is to automatically keep it up to date…
There was a problem hiding this comment.
yeah, that would be great, but if we go that way, we should go consistently.
See https://github.com/NixOS/nixpkgs/blob/release-17.09/nixos/modules/misc/version.nix#L53, for example. It backreferences 16.03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Container config example code mentions
postgresqlservice, but the correct use of that service involves settingsystem.stateVersionoption (as discovered in #30056).The actual system state version is set randomly to 17.03 because I have no preferences here