Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keybase to 1.0.33 #30098

Merged
merged 3 commits into from Oct 5, 2017
Merged

Keybase to 1.0.33 #30098

merged 3 commits into from Oct 5, 2017

Conversation

NeQuissimus
Copy link
Member

Motivation for this change

Updates

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@NeQuissimus NeQuissimus added 8.has: package (update) 9.needs: port to stable A PR needs a backport to the stable release. labels Oct 4, 2017
@NeQuissimus NeQuissimus changed the title Keybase to 1.0.33 [WIP] Keybase to 1.0.33 Oct 4, 2017
@danielfullmer
Copy link
Contributor

I'd suggest adding "kbfsgit/git-remote-keybase" to subPackages in kbfs/default.nix to enable the new git-remote-keybase functionality described in https://keybase.io/blog/encrypted-git-for-everyone

@NeQuissimus
Copy link
Member Author

NeQuissimus commented Oct 5, 2017

@carlsverre Since you are interested in keybase. Does the module work for you? It never gets loaded... It needs updating because the command has changed but even then it does not work for me.

I need help :D

I can see the module in /etc/systemd/user/keybase.service and it looks fine.
However, systemctl --user list-units --all does not list it. (and because of that neither does systemctl status user@1000.service).
I have tried giving the module "wantedBy" etc. but no luck.

@carlsverre
Copy link
Contributor

keybase service still works for me... The pull reqs that I sent work fine and I have keybase + kbfs + keybase-gui + git-remote-keybase all working well on my NixOS machine. This is what I have in my NixOS configuration:

    kbfs = {
      enable = true;
      mountPoint = "/keybase";
      extraFlags = [
          "-label kbfs"
          "-mount-type normal"
        ];
    };

https://github.com/carlsverre/nixos-configuration/blob/master/stained/services.nix#L20

@carlsverre
Copy link
Contributor

Make sure you run systemctl --user daemon-reload after rebuild - user services aren't properly reloaded.

@NeQuissimus
Copy link
Member Author

OK, let's merge this then, I basically have the same as you. I took out the service changes.
Must be something with my config then.

@NeQuissimus NeQuissimus changed the title [WIP] Keybase to 1.0.33 Keybase to 1.0.33 Oct 5, 2017
@NeQuissimus NeQuissimus merged commit f66d92a into NixOS:master Oct 5, 2017
@NeQuissimus NeQuissimus deleted the keybase_33 branch October 5, 2017 02:01
@NeQuissimus
Copy link
Member Author

I will try the module again tomorrow and then port to stable

@carlsverre
Copy link
Contributor

Sounds good, also this just landed - may want to bring it in while we are updating anyways.
keybase/kbfs#1197

@NeQuissimus
Copy link
Member Author

Everything works if I run it by hand but not the module to automatically load keybase and mount kbfs... Might be my locked down system though

@carlsverre
Copy link
Contributor

Also would be nice to point maintainers at this url to lookup keybase-gui releases:

# lookup latest version here:
# https://s3.amazonaws.com/prerelease.keybase.io/linux_binaries/deb/index.html

@NeQuissimus
Copy link
Member Author

927284f6e4 and 0053f3b86f

@carlsverre
Copy link
Contributor

Thanks!

@NeQuissimus
Copy link
Member Author

@carlsverre Just to verify: The actual NixOS kbfs module works for you?

@carlsverre
Copy link
Contributor

Yea, it's running on my machine now.

@NeQuissimus
Copy link
Member Author

dang, no matter what I do it won't do anything...

@carlsverre
Copy link
Contributor

This is what I am running on my machine:
https://github.com/carlsverre/nixpkgs/tree/stained

This is my config:
https://github.com/carlsverre/nixos-configuration

After running sudo systemctl --user restart kbfs I see this:

~/dev/config $ systemctl --user status kbfs                                                                                                             master
● kbfs.service - Keybase File System
   Loaded: loaded (/nix/store/cb2mm0dckjvi4ybv0jjp2yxfsighxrxq-unit-kbfs.service/kbfs.service; static; vendor preset: enabled)
   Active: active (running) since Thu 2017-10-05 17:50:42 PDT; 29s ago
  Process: 21204 ExecStopPost=/run/wrappers/bin/fusermount -u /keybase (code=exited, status=0/SUCCESS)
  Process: 21207 ExecStartPre=/nix/store/d4yib20lqn7krrqmm0wwbwjxjfa78xqp-coreutils-8.28/bin/mkdir -p /keybase (code=exited, status=0/SUCCESS)
 Main PID: 21209 (kbfsfuse)
   CGroup: /user.slice/user-1000.slice/user@1000.service/kbfs.service
           └─21209 /nix/store/6g8hwyn0k2mzy1h4d8c4jgq88ygxvyq9-kbfs-20171004.70800d-bin/bin/kbfsfuse -label kbfs -mount-type normal /keybase

Oct 05 17:50:44 stained kbfsfuse[21209]: github.com/keybase/kbfs/libkbfs.InitWithLogPrefix.func2
Oct 05 17:50:44 stained kbfsfuse[21209]:         /tmp/nix-build-kbfs-20171004.70800d.drv-0/go/src/github.com/keybase/kbfs/libkbfs/init.go:495
Oct 05 17:50:44 stained kbfsfuse[21209]: runtime.goexit
Oct 05 17:50:44 stained kbfsfuse[21209]:         /nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-go-1.9/share/go/src/runtime/asm_amd64.s:2337
Oct 05 17:50:44 stained kbfsfuse[21209]: 2017-10-05T17:50:44.617707-07:00 ▶ [INFO kbfs start.go:38] 003 Mounting the filesystem was a success

And I confirmed that kbfs is working. Check on your service configuration and compare it to mine.
https://github.com/carlsverre/nixos-configuration/blob/master/stained/services.nix#L20

@carlsverre
Copy link
Contributor

@NeQuissimus I think I found the issue. I was accidentally running the keybase service manually rather than via systemd which allowed the kbfs service to start fine. The fix is here: carlsverre@baf5c6e

Looks like keybase service now fork-exes at start. The -d flag prevents this.

@NeQuissimus
Copy link
Member Author

NeQuissimus commented Oct 6, 2017

@carlsverre ooh, nice, can you send a PR and I'll try it out tonight.

Edit: It won't work but I have it figured out mostly, I think. It's some systemd thing... PR incoming.

@NeQuissimus
Copy link
Member Author

#30171

@carlsverre
Copy link
Contributor

Thanks for sending that.

@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants