Add time formatters for days with ordinal suffix. Includes specs and docs. #5057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two simple, but useful methods. Happy to change the names of the methods if anyone has better suggestions. Specs included.
docs. This PR depends on the methods added in crystal-lang#5054, and so cannot be merged unless crystal-lang#5054 is merged first.
|
Also depends on ICU, should be extracted as shard. I was started crystal-cldr but have no time to finish it yet. |
|
This is not common so I'm not sure we should merge this. Does any other language provide this functionality? |
|
It should be extracted as separate shard anyway. It's related to Unicode CLDR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on the methods added in #5054, and so cannot be merged
unless #5054 is merged first.