twolame: init at 2017-09-27 #29914
twolame: init at 2017-09-27 #29914
Conversation
| ''; | ||
| homepage = http://www.twolame.org/; | ||
| license = with licenses; [ lgpl2Plus ]; | ||
| }; |
There was a problem hiding this comment.
Please add platforms and maintainers.
There was a problem hiding this comment.
I will put "unix", but I don't have a Darwin here to test it.
| stdenv.mkDerivation rec { | ||
|
|
||
| name = "twolame-${version}"; | ||
| version = "git-2017-09-27"; |
There was a problem hiding this comment.
https://nixos.org/nixpkgs/manual/#sec-package-naming
The version part of the name attribute must start with a digit (following a dash) — e.g., "hello-0.3.1rc2".
If a package is not a release but a commit from a repository, then the version part of the name must be the date of that (fetched) commit. The date must be in "YYYY-MM-DD" format. Also append "unstable" to the name - e.g., "pkgname-unstable-2014-09-23".
There was a problem hiding this comment.
But don't append unstable, since this is the only version and you treat it as stable.
There was a problem hiding this comment.
In sum: erasing the git- part?
There was a problem hiding this comment.
Yes. (And from the commit message too.)
| sha256 = "1rq3yc8ygzdqid9zk6pixmm4w9sk2vrlx217lhn5bjaglv7iyf7x"; | ||
| }; | ||
|
|
||
| buildInputs = [ autoreconfHook pkgconfig libsndfile ]; |
There was a problem hiding this comment.
Please move autoreconfHook and pkgconfig to nativeBuildInputs.
AndersonTorres
changed the title
|
Thank you! |
Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)