Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wmsm.app: compile in gnu89 mode #29909

Merged
merged 1 commit into from Sep 28, 2017
Merged

wmsm.app: compile in gnu89 mode #29909

merged 1 commit into from Sep 28, 2017

Conversation

edef1c
Copy link
Member

@edef1c edef1c commented Sep 28, 2017

Motivation for this change

It expects inline to expose a symbol, which hasn't been the case since
C99, breaking linking.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

it expects `inline` to expose a symbol, which hasn't been the case since
C99, breaking linking.
@erincandescent
Copy link
Contributor

This will have broken when GCC5 changed the default from -std=gnu89 to -std=gnu11

@orivej orivej merged commit 730b782 into NixOS:master Sep 28, 2017
@edef1c edef1c deleted the wmsm-gnu89 branch September 29, 2017 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants