Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mockingbirdnest/Principia
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: bf6a1c543aa9
Choose a base ref
...
head repository: mockingbirdnest/Principia
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 4f2991673ac5
Choose a head ref
  • 2 commits
  • 3 files changed
  • 1 contributor

Commits on Sep 25, 2017

  1. Fix the remaining warnings.

    @pleroy
    pleroy committed Sep 25, 2017
    Copy the full SHA
    4e24f3e View commit details

Commits on Sep 28, 2017

  1. Merge pull request #1582 from pleroy/1581 

    Fix the remaining warnings
    @pleroy
    pleroy authored Sep 28, 2017
    Copy the full SHA
    4f29916 View commit details
Showing with 10 additions and 14 deletions.
  1. +1 −1 base/array_body.hpp
  2. +0 −4 ksp_plugin_test/interface_renderer_test.cpp
  3. +9 −9 quantities/parser_body.hpp
2 changes: 1 addition & 1 deletion base/array_body.hpp
View file
Original file line number Diff line number Diff line change
@@ -45,7 +45,7 @@ Array<Element> UniqueArray<Element>::get() const {
template<typename Element, std::int32_t max_size>
template<typename... Args>
constexpr BoundedArray<Element, max_size>::BoundedArray(Args&&... args)
: data_{std::forward<Args>(args)...},
: data_{{std::forward<Args>(args)...}},
size_(sizeof...(args)) {}

template<typename Element, std::int32_t max_size>
4 changes: 0 additions & 4 deletions ksp_plugin_test/interface_renderer_test.cpp
View file
Original file line number Diff line number Diff line change
@@ -46,10 +46,6 @@ Index const celestial_index = 1;
Index const parent_index = 2;
Index const unused = 666;

int const trajectory_size = 10;

XYZ parent_position = {4, 5, 6};

} // namespace

class InterfaceRendererTest : public ::testing::Test {
18 changes: 9 additions & 9 deletions quantities/parser_body.hpp
View file
Original file line number Diff line number Diff line change
@@ -21,7 +21,7 @@ struct ExtractDimensions {};
template<>
struct ExtractDimensions<double> {
static constexpr RuntimeDimensions dimensions() {
return {0, 0, 0, 0, 0, 0, 0, 0};
return {{0, 0, 0, 0, 0, 0, 0, 0}};
}
};

@@ -43,14 +43,14 @@ struct ExtractDimensions<
LuminousIntensityExponent,
AngleExponent>>> {
static constexpr RuntimeDimensions dimensions() {
return {LengthExponent,
MassExponent,
TimeExponent,
CurrentExponent,
TemperatureExponent,
AmountExponent,
LuminousIntensityExponent,
AngleExponent};
return {{LengthExponent,
MassExponent,
TimeExponent,
CurrentExponent,
TemperatureExponent,
AmountExponent,
LuminousIntensityExponent,
AngleExponent}};
}
};