Add Int#ordinal and Int#to_ordinal methods #5054
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two simple, but useful methods. Happy to change the names of the methods if anyone has better suggestions. Specs included.
molovo
force-pushed
the
add_ordinal_methods
branch
from
eede965
to
ca0ec67
Compare
molovo
added a commit
to molovo/crystal
that referenced
this pull request
Sep 28, 2017
docs. This PR depends on the methods added in crystal-lang#5054, and so cannot be merged unless crystal-lang#5054 is merged first.
|
I'm sorry but it should be outside stdlib unless full ICU included. Separated Just because English just one of languages. |
|
@akzhan that's a very fair point that I totally overlooked |
|
See also amberframework/amber#56. |
|
I think this should be provided in a shard. It's too English-centric. (I know there's Time code for dealing with month names in English, but that's a bit all over the place in programming and data, so there it's fine) |
|
Looks like it should be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two simple, but useful methods. Happy to change the names of the methods if anyone has better suggestions. Specs and docs included.