Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

platformio: 2.10.3 -> 3.4.1 #29911

Merged
merged 4 commits into from Oct 2, 2017
Merged

platformio: 2.10.3 -> 3.4.1 #29911

merged 4 commits into from Oct 2, 2017

Conversation

makefu
Copy link
Contributor

@makefu makefu commented Sep 28, 2017 •
edited

Motivation for this change

platformio was too old to build https://github.com/arendst/Sonoff-Tasmota

bump as deps:
pyserial: 2.7 -> 3.4
semantic_version: 2.4.2 -> 2.6.0

add patch for fixing broken PYTHONPATH detection function. Without this patch the chrooted platformio will crash when forking itself and trying to import requests afterwards. We know how the search path looks like because we prepare it in the .platformio-wrapped executable.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.
  • split commit

Broken Deps

  • Octoprint - pinned deps
  • Tiros - equires requests2, seems to have never built correctly

@makefu makefu requested a review from FRidh as a code owner September 28, 2017 23:33
FRidh
FRidh requested changes Sep 29, 2017
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

  • One commit per expression
  • Can you move the expressions you touch into python-modules

@makefu makefu changed the title platformio: 2.10.3 -> 3.4.1 [WIP] platformio: 2.10.3 -> 3.4.1 Sep 29, 2017
@makefu makefu force-pushed the pkgs/platformio/update branch 2 times, most recently from 5c09085 to 99e4bb7 Compare September 29, 2017 13:06
@makefu makefu changed the title [WIP] platformio: 2.10.3 -> 3.4.1 platformio: 2.10.3 -> 3.4.1 Sep 29, 2017
@makefu
Copy link
Contributor Author

makefu commented Sep 29, 2017

@FRidh okay done, mind having a look?

@makefu makefu force-pushed the pkgs/platformio/update branch 2 times, most recently from cac4884 to 8aaec3c Compare September 29, 2017 13:13
@orivej orivej merged commit 61adee9 into NixOS:master Oct 2, 2017
@makefu
Copy link
Contributor Author

makefu commented Oct 2, 2017

thanks!

@orivej
Copy link
Contributor

orivej commented Oct 2, 2017

@abbradar We have unpinned some dependencies from octoprint; pinging you as the maintainer: 7bc1d33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh requested changes

Assignees
No one assigned
Labels
6.topic: python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@makefu @orivej @FRidh