Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "cudatoolkit: Move libcudart to a separate output" #29920

Closed
wants to merge 1 commit into from
Closed

Revert "cudatoolkit: Move libcudart to a separate output" #29920

wants to merge 1 commit into from

Conversation

jyp
Copy link
Contributor

@jyp jyp commented Sep 29, 2017

This reverts commit bb1c9b0.

Motivation for this change

See #29798

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jyp jyp mentioned this pull request Sep 29, 2017
Closed
@edolstra
Copy link
Member

👎, this would increase the closure size of Blender by a couple of gigabytes.

@jyp
Copy link
Contributor Author

jyp commented Sep 29, 2017

@edolstra Could you advise on how to fix #29798?

@edolstra
Copy link
Member

Probably the rpath set in tensorflow's postFixup phase should be changed from cudatoolkit to cudatoolkit.lib (or maybe cudatoolkit.lib cudatoolkit, in case it's using other libraries from cudatoolkit - but in that case maybe those should be moved to lib as well).

@jyp jyp closed this Nov 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jyp @edolstra