Fix be_nil expectation to use .nil? #5091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
force-pushed
the
jm-nil-expectation
branch
from
4bf9372
to
6ba9ad2
Compare
bew
reviewed
Oct 9, 2017
| @@ -8,7 +8,7 @@ describe "YAML" do | |||
| it { YAML.parse_all("---\nfoo\n---\nbar\n").should eq(["foo", "bar"]) } | |||
| it { YAML.parse("foo: bar").should eq({"foo" => "bar"}) } | |||
| it { YAML.parse("--- []\n").should eq([] of YAML::Type) } | |||
| it { YAML.parse("---\n...").should be_nil } | |||
| it { YAML.parse("---\n...").should eq nil } | |||
There was a problem hiding this comment.
can you explain why it should eq nil and not be nil?
There was a problem hiding this comment.
YAML.parse returns a YAML::Any, thus it is not nil but any == nil still returns true if any.value is nil.
bcardiff
approved these changes
Oct 9, 2017
RX14
approved these changes
Oct 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
be_nilexpectation compares the actual value withnilusing the==operator. This operator can be redefined by any class. This makes it unreliable for testing if a value is actuallynil.I would expect the
be_nilexpectation to test with.nil?(which as a compiler feature cannot be redefined).beis used of identity whileeqtests equality.If it should matter for any purpose, the current behaviour of the
==operator can easily be accomplished by usingeq nilinstead ofbe_nil.