Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python.pkgs.django: make gdal support optional #30254

Merged
merged 1 commit into from Oct 20, 2017
Merged

python.pkgs.django: make gdal support optional #30254

merged 1 commit into from Oct 20, 2017

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Oct 9, 2017

Motivation for this change

Reduce closure size of Django from 586 MB to 155 MB.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@FRidh FRidh requested a review from lsix October 9, 2017 16:24
@FRidh
Copy link
Member Author

FRidh commented Oct 9, 2017

Perhaps add an example in the docs showing how to enable gdal support?

@lsix
Copy link
Member

lsix commented Oct 9, 2017

looks good to me. It is reasonable to (massively) reduce the closure size since everyone do not require gdal.

Having some documentation could be appreciated.

@FRidh FRidh merged commit 7f43dd3 into NixOS:master Oct 20, 2017
@FRidh FRidh deleted the django-gdal branch October 20, 2017 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsix lsix Awaiting requested review from lsix

Assignees
No one assigned
Labels
6.topic: closure-size 6.topic: python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FRidh @lsix