Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qt5: 5.9.1 -> 5.9.2 #30255

Merged
merged 1 commit into from Oct 12, 2017
Merged

qt5: 5.9.1 -> 5.9.2 #30255

merged 1 commit into from Oct 12, 2017

Conversation

bkchr
Copy link
Contributor

@bkchr bkchr commented Oct 9, 2017 •
edited

Motivation for this change

For qtwebkit there is no 5.9.2, so this sticks to 5.9.1.

@ttuegel

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@FRidh FRidh requested a review from ttuegel October 9, 2017 17:47
@ttuegel
Copy link
Member

ttuegel commented Oct 12, 2017

Thanks, I am testing this now.

@ttuegel ttuegel merged commit 4cf0b6b into NixOS:master Oct 12, 2017
@timokau
Copy link
Member

timokau commented Oct 18, 2017

Mixing qt 5.9.2 with qtwebkit 5.9.1 breaks qutebrowser (qutebrowser/qutebrowser#3140) and telegram-desktop. Is there some way we can fix this?

@ttuegel
Copy link
Member

ttuegel commented Oct 18, 2017

This problem is not caused by "mixing Qt 5.9.2 and QtWebkit 5.9.1" because our QtWebkit 5.9.1 is compiled against Qt 5.9.2. QtWebkit is not a part of Qt anymore, so the QtWebkit version number has nothing to do with the Qt version number whatsoever. Instead, this is a common issue on NixOS caused by having outdated packages in your user or system environment. (Check nix-env -q.) If the problem persists after you update your environments, please open a separate issue.

@timokau timokau mentioned this pull request Oct 18, 2017
Closed
ttuegel added a commit to ttuegel/nixpkgs that referenced this pull request Nov 2, 2017
@ttuegel
Revert "Merge pull request NixOS#30255 from bkchr/qt_5_9_2"
4866f16 
This reverts commit 4cf0b6b, reversing
changes made to 756b9c7.

Qt 5.9.2 is reverted to Qt 5.9.1, as recommended by KDE upstream due to
https://bugreports.qt.io/browse/QTBUG-64017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel ttuegel approved these changes

Assignees
No one assigned
Labels
6.topic: qt/kde
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bkchr @ttuegel @timokau @FRidh