selendroid: fix selendroid-selenium and 0.11.0 -> 0.17.0 #30430
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I unfortunately tested the wrong executable in #30186. The
selendroid-selenium
executable was broken indeed. Because I couldn't find any docs, I tested the version before the selenium update. This one was broken as well, so it seems that this was broken some time ago. My best guess at what it was supposed to do is this docs session about scaling selendroid, so I made it start a selendroid hub.I also updated the version along the way.
Things done
Changed
selendroid-selenium
to start a selendroid hubTested both standalone as well as grid configuration by running a simple test
Tested using sandboxing (nix.useSandbox on NixOS, or option
build-use-sandbox
innix.conf
on non-NixOS)Built on platform(s)
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using
nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in
./result/bin/
)Fits CONTRIBUTING.md.