New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] docbook: put DTDs in $out/share/xml instead of $out/xml #30428
Conversation
Instead of |
You may also want to do a similar action for SGML derivation. Also I opened #30457 which fixes the paths in existing derivations. |
@@ -1,7 +1,8 @@ | |||
source $stdenv/setup | |||
|
|||
mkdir -p $out/xml/dtd/docbook | |||
cd $out/xml/dtd/docbook | |||
dir=$out/share/${stdenv.lib.replaceStrings [ "-xml" ] [ "" ] name}/dtd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would not work. You can use ${name/-xml/}
but people on IRC recommend moving the builder to a Nix expression (generic.nix
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know - I was trying out some things but had to leave the computer I was working on, hence a commit named "fef". I don't like using builder.sh
either - it's much easier to grok as part of the derivation directly.
What is the status of this pull request? |
Closing due to lack of activity, feel free re-open this if needed. |
Motivation for this change
Currently, the docbook derivation puts things into $out/xml which really should be $out/share/xml.
This causes a truly massive rebuild so I'm not sure if it's really worth it and I have NOT run
nox-review wip
on this.Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)