Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] docbook: put DTDs in $out/share/xml instead of $out/xml #30428

Closed
wants to merge 2 commits into from
Closed

[WIP] docbook: put DTDs in $out/share/xml instead of $out/xml #30428

wants to merge 2 commits into from
+3 −2

Conversation

peterhoeg
Copy link
Member

Motivation for this change

Currently, the docbook derivation puts things into $out/xml which really should be $out/share/xml.

This causes a truly massive rebuild so I'm not sure if it's really worth it and I have NOT run nox-review wip on this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@peterhoeg peterhoeg added the 1.severity: mass-rebuild This PR causes a large number of packages to rebuild label Oct 15, 2017
@jtojnar
Copy link
Member

jtojnar commented Oct 15, 2017

Instead of share/xml/dtd/docbook, we might want to use share/xml/docbook-4.x/dtd to mirror docbook5.

@jtojnar jtojnar mentioned this pull request Oct 16, 2017
Closed
8 tasks
@jtojnar
Copy link
Member

jtojnar commented Oct 16, 2017

You may also want to do a similar action for SGML derivation.

Also I opened #30457 which fixes the paths in existing derivations.

@peterhoeg peterhoeg changed the title docbook: put DTDs in $out/share/xml instead of $out/xml [WIP] docbook: put DTDs in $out/share/xml instead of $out/xml Oct 17, 2017
jtojnar
jtojnar reviewed Oct 17, 2017
View reviewed changes
pkgs/data/sgml+xml/schemas/xml-dtd/docbook/builder.sh
@@ -1,7 +1,8 @@
source $stdenv/setup

mkdir -p $out/xml/dtd/docbook
cd $out/xml/dtd/docbook
dir=$out/share/${stdenv.lib.replaceStrings [ "-xml" ] [ "" ] name}/dtd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would not work. You can use ${name/-xml/} but people on IRC recommend moving the builder to a Nix expression (generic.nix).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know - I was trying out some things but had to leave the computer I was working on, hence a commit named "fef". I don't like using builder.sh either - it's much easier to grok as part of the derivation directly.

@matthewbauer matthewbauer added the 2.status: work-in-progress This PR isn't done label Mar 22, 2018
@mmahut
Copy link
Member

mmahut commented Aug 3, 2019

What is the status of this pull request?

@mmahut
Copy link
Member

mmahut commented Oct 5, 2019

Closing due to lack of activity, feel free re-open this if needed.

@mmahut mmahut closed this Oct 5, 2019
@jtojnar jtojnar mentioned this pull request Dec 14, 2019
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar

Assignees
No one assigned
Labels
1.severity: mass-rebuild This PR causes a large number of packages to rebuild 2.status: work-in-progress This PR isn't done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@peterhoeg @jtojnar @mmahut @matthewbauer