crashdump module: fix evaluation. #30415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @viric. |
|
All fixes welcome! I can't easily evaluate it other than to repeat the claimed tests. |
|
I've got no experience with the crashdump module, but IMHO it'd be nice to have more info in the commit message than "fix evaluation", to help users/reviewers. |
The module would fail to evaluate: ```The option value `boot.crashDump.kernelPackages' in ... is not a package.``` Removed the option boot.crashDump.kernelPackage in favor of using boot.kernelPatches which automatically chooses the same kernel version as boot.kernelPackage instead of overriding it. Added option boot.crashDump.reservedMemory to customized crash kernel memory. Changed the default of boot.crashDump.kernelParams as the current one seemed to have no effect.
|
I added a description in the commit message. |
bjornfor
approved these changes
Oct 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
the module was broken. It wouldn't even evaluate.
To work properly, this PR depends on #30413
The increase in memory size is motivated by my own needs and https://bugs.launchpad.net/ubuntu/+source/kexec-tools/+bug/785394
Is using kernelPatches to change kernel configuration options the canonical way to do so ? Should the documentation mention that ?
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)