Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBS-9513: Fix UI locale with country code #560

Merged
merged 3 commits into from Oct 18, 2017

Conversation

yvanzo
Copy link
Contributor

@yvanzo yvanzo commented Oct 14, 2017

Fix bug MBS-9513 and move UI locale Estonian (Estonia) to just Estonia as requested by @reosarevok.

The `lang` cookie holds locale code in BCP 47 format (with hyphen),
whereas it is compared to POSIX locale codes (with underscore).

Because the `lang` cookie was set in BCP 47 format but read as a
POSIX locale, it caused locales with country code to malfunction.

This patch updates the read of `lang` cookie to follow BCP 47 too.
of Perl module DateTime::Locale since version 0.90 (2015-09-27).
This was totally unneeded, according to @reosarevok 's ancestors.
@yvanzo yvanzo requested a review from mwiencek October 14, 2017 13:50
@yvanzo yvanzo merged commit fb8b358 into metabrainz:master Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants