New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.git-annex-adapter: init at 0.2.0 #30411
Conversation
buildPythonPackage rec { | ||
name = "git-annex-adapter-${version}"; | ||
version = "0.2.0"; | ||
format = "wheel"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Building from the actual source instead of a wheel has preference. You can download a tarball from https://github.com/alpernebbi/git-annex-adapter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we mention this in the manual?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may add it explicitly with regards to wheels, but its pretty much the rule throughout Nixpkgs that we prefer to build from source.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Building right from GitHub now :)
7316ed7
to
041ddcb
Compare
ping @FRidh |
eject # `rev` is needed in tests/test_process.py | ||
]; | ||
|
||
propagatedBuildInputs = [ pygit2 gitMinimal git-annex ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Programs like git
won't be available during runtime. The proper solution is to patch the source code and hardcode references to git
.
Status? |
Sorry, didn't work on it, but as soon as I do (this year for sure), I'll write you back. |
Motivation for this change
Python 2 was disabled because there is only a wheel for py3 on PyPI.
I tested that this works with a derivation for git-annex-metadata-gui for which I will create a PR after this one has been merged.
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)