Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.git-annex-adapter: init at 0.2.0 #30411

Closed
wants to merge 1 commit into from

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented Oct 14, 2017

Motivation for this change

Python 2 was disabled because there is only a wheel for py3 on PyPI.
I tested that this works with a derivation for git-annex-metadata-gui for which I will create a PR after this one has been merged.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda requested a review from FRidh as a code owner October 14, 2017 14:54
buildPythonPackage rec {
name = "git-annex-adapter-${version}";
version = "0.2.0";
format = "wheel";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Building from the actual source instead of a wheel has preference. You can download a tarball from https://github.com/alpernebbi/git-annex-adapter

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we mention this in the manual?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may add it explicitly with regards to wheels, but its pretty much the rule throughout Nixpkgs that we prefer to build from source.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Building right from GitHub now :)

@dotlambda
Copy link
Member Author

ping @FRidh

eject # `rev` is needed in tests/test_process.py
];

propagatedBuildInputs = [ pygit2 gitMinimal git-annex ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Programs like git won't be available during runtime. The proper solution is to patch the source code and hardcode references to git.

@FRidh
Copy link
Member

FRidh commented Nov 22, 2017

Status?

@dotlambda
Copy link
Member Author

Sorry, didn't work on it, but as soon as I do (this year for sure), I'll write you back.
In the meantime, I'll close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants