Fix "batch" command on NixOS #30423
Merged
Fix "batch" command on NixOS #30423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjornfor
force-pushed
the
fix-atd-batch
branch
from
1a098d8
to
a53e658
Compare
|
Works fine now on NixOS 17.09 with this patch and looks like it shouldn't break the package on other OSes or without the NixOS module. |
|
You could also remove "batch" from the from the list of programs to be wrapped in the atd service module. It probably never worked in the first place and now doesn't serve a purpose. |
bjornfor
force-pushed
the
fix-atd-batch
branch
from
a53e658
to
6067fd9
Compare
|
Good catch. Fixed. |
"batch" is a shell script so invoking it via setuid wrapper never worked anyway. (The kernel drops perms on executables with shebang.) A previous nixpkgs commit made "batch" invoke the NixOS setuid "at" wrapper to gain needed privileges. Thanks to @yesbox for noticing.
bjornfor
force-pushed
the
fix-atd-batch
branch
from
6067fd9
to
497108b
Compare
|
Applied to master and cherry-picked to release-17.09. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fix #12392
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)