Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SOLR-60: Bring Instruments to search parity #39

Merged
merged 1 commit into from Oct 15, 2017
Merged

SOLR-60: Bring Instruments to search parity #39

merged 1 commit into from Oct 15, 2017

Conversation

samj1912
Copy link
Contributor

No description provided.

@samj1912 samj1912 requested review from mayhem and mineo October 14, 2017 20:46
@mayhem
Copy link
Member

mayhem commented Oct 15, 2017

I liked how you provided 4 links in the last PR to see what is going on. I can get what you're doing from the code, but I don't know what the motivation is. More context please.

@samj1912
Copy link
Contributor Author

samj1912 commented Oct 15, 2017 •
edited

See
https://solr.musicbrainz.org/solr/instrument/select?indent=on&q=tag:quadrivium&wt=mbxml
vs
https://musicbrainz.org/ws/2/instrument?query=tag:quadrivium

Tags are not being displayed or indexed when they should be

mayhem
mayhem approved these changes Oct 15, 2017
View reviewed changes
Copy link
Member

@mayhem mayhem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarifications! 🌵 !

@mayhem mayhem merged commit 5a9c91c into metabrainz:master Oct 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayhem mayhem mayhem approved these changes

@mineo mineo Awaiting requested review from mineo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@samj1912 @mayhem