tqsl: init at 2.3.1 #30146
Merged
tqsl: init at 2.3.1 #30146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Oct 6, 2017
| set_source_files_properties(location.cpp PROPERTIES COMPILE_DEFINITIONS CONFDIR="${CMAKE_INSTALL_PREFIX}/share/TrustedQSL/") | ||
| set(HEADERS_TO_INSTALL tqsllib.h tqslerrno.h cabrillo.h adif.h tqslconvert.h) | ||
| -install(TARGETS tqsllib DESTINATION lib$(LIB_SUFFIX)) | ||
| +install(TARGETS tqsllib DESTINATION lib${LIB_SUFFIX}) |
There was a problem hiding this comment.
This might be also worth reporting upstream.
There was a problem hiding this comment.
Already have. They don't seem to have an open bug tracker, but there's a help email and a trouble ticket form. I submitted to both.
There was a problem hiding this comment.
Just dug this up: https://sourceforge.net/p/trustedqsl/mailman/message/35820793/
They've already fixed it. Just haven't released the changes yet.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Adding a package I want to use
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)