Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tqsl: init at 2.3.1 #30145

Closed
wants to merge 1 commit into from
Closed

tqsl: init at 2.3.1 #30145

wants to merge 1 commit into from

Conversation

dpflug
Copy link
Contributor

@dpflug dpflug commented Oct 6, 2017

Motivation for this change

Adding a package I want to use

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dpflug dpflug requested a review from edolstra as a code owner October 6, 2017 01:34
vyp
vyp reviewed Oct 6, 2017
View reviewed changes
pkgs/top-level/all-packages.nix Outdated
zlib = zlib;
db = db;
curl = curl;
wxGTK = wxGTK;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need these? Also why not just name libssl openssl?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used libssl because I saw some other package do it.

You're right; I don't need those. I forgot they'd automatically be in scope.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. I just did a quick check and it looks like only axel names openssl as libssl. 🤷‍♀️

@dpflug dpflug closed this Oct 6, 2017
@dpflug
Copy link
Contributor Author

dpflug commented Oct 6, 2017

Corrections in #30146

@vyp
Copy link
Member

vyp commented Oct 6, 2017

Also, in case you don't know, you don't need to make a new PR to update it, you can just push to your branch.

@dpflug
Copy link
Contributor Author

dpflug commented Oct 6, 2017

I pushed the corrections and didn't see this one update. Must've been cached somewhere, or GitHub didn't propagate the updates quickly enough. I'll be more patient in the future.

@vyp
Copy link
Member

vyp commented Oct 6, 2017

Fair enough, no problem, it was just in case you didn't know. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyp vyp vyp left review comments

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dpflug @vyp