Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/modules/services/misc/nzbget: systemd unit PreStart fixes nzbget.conf paths broken by upgrade / garbage collection cycle #30144

Closed
wants to merge 0 commits into from
Closed

nixos/modules/services/misc/nzbget: systemd unit PreStart fixes nzbget.conf paths broken by upgrade / garbage collection cycle #30144

wants to merge 0 commits into from

Conversation

csingley
Copy link
Contributor

@csingley csingley commented Oct 6, 2017 •
edited

Motivation for this change

Fixes #24769.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@csingley
Copy link
Contributor Author

So the latest commit on this PR is somewhat more polite. Instead of summarily overwriting the config file, it just checks the paths in the config file; if they're broken it overrides them with paths to the currently-installed nzbget derivation.

@adisbladis adisbladis mentioned this pull request Oct 27, 2017
Closed
8 tasks
@csingley csingley closed this Oct 29, 2017
@csingley csingley mentioned this pull request Oct 30, 2017
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fadenb fadenb fadenb approved these changes

@edolstra edolstra Awaiting requested review from edolstra

@edwtjo edwtjo Awaiting requested review from edwtjo

@FRidh FRidh Awaiting requested review from FRidh

@peti peti Awaiting requested review from peti

@rycee rycee Awaiting requested review from rycee

Assignees
No one assigned
Labels
12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nzbget config WebDir contains garbage collectable path
3 participants
@csingley @fadenb @Janik-Haag