Fix coreclr and upgrade to 2.0.0 #30156
Conversation
| ./build.sh $BuildArch $BuildType | ||
| # set +x |
There was a problem hiding this comment.
Did you left this unintentionally?
There was a problem hiding this comment.
Yep, was troubleshooting. Will be removed in the final version. Thanks, @Mic92
|
Some other shellscripts were also had the wrong shebang (you did not notice that due missing sandbox). I will push a fix soon. |
|
Looks much better now. Can you test an actual project with it? |
| maintainers = with stdenv.lib.maintainers; [ obadz ]; | ||
| license = stdenv.lib.licenses.mit; | ||
| broken = true; # CoreCLR has proven to be very difficult to package. PRs welcome if someone wants to shave that yak. | ||
| maintainers = with maintainers; [ obadz ]; |
There was a problem hiding this comment.
@copumpkin yes, I am interested
There was a problem hiding this comment.
@copumpkin: no, feel free to remove me. Cheers.
|
@GrahamcOfBorg coreclr |
There was a problem hiding this comment.
shrinking /nix/store/32873lyx0d0nc8d5jkv4ghjdzhn4y9dg-coreclr-2.0.0/share/dotnet/System.Globalization.Native.so
shrinking /nix/store/32873lyx0d0nc8d5jkv4ghjdzhn4y9dg-coreclr-2.0.0/share/dotnet/libsuperpmi-shim-counter.so
shrinking /nix/store/32873lyx0d0nc8d5jkv4ghjdzhn4y9dg-coreclr-2.0.0/share/dotnet/libsuperpmi-shim-collector.so
shrinking /nix/store/32873lyx0d0nc8d5jkv4ghjdzhn4y9dg-coreclr-2.0.0/share/dotnet/libprotononjit.so
shrinking /nix/store/32873lyx0d0nc8d5jkv4ghjdzhn4y9dg-coreclr-2.0.0/share/dotnet/createdump
shrinking /nix/store/32873lyx0d0nc8d5jkv4ghjdzhn4y9dg-coreclr-2.0.0/share/dotnet/libsos.so
stripping (with flags -S) in /nix/store/32873lyx0d0nc8d5jkv4ghjdzhn4y9dg-coreclr-2.0.0/bin
patching script interpreter paths in /nix/store/32873lyx0d0nc8d5jkv4ghjdzhn4y9dg-coreclr-2.0.0
checking for references to /tmp/nix-build-coreclr-2.0.0.drv-0 in /nix/store/32873lyx0d0nc8d5jkv4ghjdzhn4y9dg-coreclr-2.0.0...
/nix/store/32873lyx0d0nc8d5jkv4ghjdzhn4y9dg-coreclr-2.0.0
|
@Mic92 @kuznero Nitpick: this does not fit Contributing.md; 4 out of the 6 commits are not prefixed by the package they modify (here coreclr). Seeing "Use build type parameter" in the log feels really odd 😉 |
Motivation for this change
Fix coreclr package currently marked as broken. In addition upgrade it to latest and greatest 2.0.0. Related to issue #25498. Ping @obadz @copumpkin, @janvorli.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)