Fix to work with Python3 #119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As Nikola is dropping support for Python2 there is no point in having a not merged plugin working on 2 and not on 3.
| % for k, v in options.iteritems(): | ||
| % if isinstance(v, unicode): | ||
| % for k, v in options.items(): | ||
| % if isinstance(v, str): |
There was a problem hiding this comment.
If you really want to keep this working in python2, you could use nikola.utils.unicode_str which is always the right thing.
There was a problem hiding this comment.
Is it accessible from within templates? (and why is there so much logic in this template?)
|
This PR seems to apply to a plugin that is not there anymore? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Nikola is dropping support for Python2 there is no point in having a not merged plugin working on 2 and not on 3.