treat deadlocks as circular require - as MRI does it #3370
Merged
+1
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll have a look. |
this eventually fixes #3341 in the sense that both testcases do not produce deadlocks anymore. Sponsored by Lookout Inc.
mkristian
changed the title
headius
added a commit
that referenced
this pull request
Mar 3, 2016
treat deadlocks as circular require - as MRI does it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3341 has two simple tests which produces deadlocks on the current master branch.
this PR does fix it to the extend that I do not see deadlocks anymore.
@headius please review and I would some input on tests, i.e. it should be possible to run those tests from #3341 on CI but I am not if this makes sense