hl1110 : init at 3.0.1-1 #32605
Merged
hl1110 : init at 3.0.1-1 #32605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orivej
reviewed
Dec 23, 2017
pkgs/top-level/all-packages.nix
Outdated
| @@ -8761,6 +8761,8 @@ with pkgs; | |||
| inherit (perlPackages) IOStringy; | |||
| }; | |||
|
|
|||
| hl1110 = callPackage_i686 ../misc/cups/drivers/hl1110 { }; | |||
There was a problem hiding this comment.
It belongs near other cups/drivers in all-packages.nix.
Could you rename it to cups-brother-hl1110?
There was a problem hiding this comment.
Just wanted to let you know that I've read your comment, but I haven't been in the position to test the change; even though it is trivial. Will get to it this week.
This commit adds a cups driver for the Brother HL1110 printer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a driver to cups for the Brother HL1110 printer.
Things done
This package is based on 'mfcj470dw-cupswrapper' and 'mfcj470dwlpr', and merged into a single nix file. I've decided to do this because this way because it requires less patching to the scripts and other source files.
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)