Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signal-desktop-beta: init at 1.1.0-beta.5 #32619

Merged
merged 1 commit into from Dec 18, 2017

Conversation

benley
Copy link
Member

@benley benley commented Dec 12, 2017

Signal is a bit like google-chrome, wherein the beta version is independent from the release builds and uses different data locations and binary names.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

description = "Signal Private Messenger for the Desktop.";
homepage = https://signal.org/;
license = lib.licenses.gpl3;
maintainers = [ lib.maintainers.ixmatus ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not you.

/cc @ixmatus

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct; @ixmatus is listed as maintainer for the regular non-beta Signal package, so I assumed they would desire to be listed here as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine to list me as a maintainer. @benley if you have your github user added to the maintainers set then I think it's appropriate for you to be listed there as well, otherwise it's fine by me to be the listed maintainer.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I will add myself. Thanks.

Copy link
Contributor

@ixmatus ixmatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the discussion of the maintainers list I have one request to tweak the meta.description of the derivation. LGTM otherwise.

'';

meta = {
description = "Signal Private Messenger for the Desktop.";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this description should make note of the fact that this derivation is for a beta release of Signal Private Messenger for the Desktop...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Signal is a bit like google-chrome, wherein the beta version
is independent from the release builds and uses different data
locations and binary names.
@benley benley merged commit 4ec5c79 into NixOS:master Dec 18, 2017
@benley benley deleted the signal-desktop-beta branch December 18, 2017 22:21
@ixmatus
Copy link
Contributor

ixmatus commented Jan 3, 2018

@benley I'm not sure if you receive the hydra build failure emails but I received one for a recent build on master: https://hydra.nixos.org/build/66165023

It looks like they do not retain released beta artifacts (i.e. the deb file can't be fetched by Nix now).

@ixmatus
Copy link
Contributor

ixmatus commented Jan 3, 2018

I suppose I should create an issue ticket too.

@benley
Copy link
Member Author

benley commented Jan 3, 2018

Please do - I'll try to remember to update the URL after work but a bug # always helps :-)

@ixmatus
Copy link
Contributor

ixmatus commented Jan 3, 2018

@benley #33401

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants