New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
signal-desktop-beta: init at 1.1.0-beta.5 #32619
Conversation
0ffcdf0
to
c3e9751
Compare
description = "Signal Private Messenger for the Desktop."; | ||
homepage = https://signal.org/; | ||
license = lib.licenses.gpl3; | ||
maintainers = [ lib.maintainers.ixmatus ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not you.
/cc @ixmatus
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct; @ixmatus is listed as maintainer for the regular non-beta Signal package, so I assumed they would desire to be listed here as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fine to list me as a maintainer. @benley if you have your github user added to the maintainers set then I think it's appropriate for you to be listed there as well, otherwise it's fine by me to be the listed maintainer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I will add myself. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the discussion of the maintainers list I have one request to tweak the meta.description of the derivation. LGTM otherwise.
''; | ||
|
||
meta = { | ||
description = "Signal Private Messenger for the Desktop."; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this description should make note of the fact that this derivation is for a beta release of Signal Private Messenger for the Desktop...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
Signal is a bit like google-chrome, wherein the beta version is independent from the release builds and uses different data locations and binary names.
c3e9751
to
83ab54f
Compare
@benley I'm not sure if you receive the hydra build failure emails but I received one for a recent build on It looks like they do not retain released beta artifacts (i.e. the deb file can't be fetched by Nix now). |
I suppose I should create an issue ticket too. |
Please do - I'll try to remember to update the URL after work but a bug # always helps :-) |
Signal is a bit like google-chrome, wherein the beta version is independent from the release builds and uses different data locations and binary names.
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)