Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skypeforlinux: 8.11.0.4 -> 8.11.76.8 #32604

Closed
wants to merge 3 commits into from
Closed

skypeforlinux: 8.11.0.4 -> 8.11.76.8 #32604

wants to merge 3 commits into from

Conversation

rycee
Copy link
Member

@rycee rycee commented Dec 12, 2017

Motivation for this change

Bump Skype to the latest version. This may have to be backported to 17.09 because the 5.5.0.1 version appears to be disabled 馃檨

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@rycee
Copy link
Member Author

rycee commented Dec 12, 2017

Maintainer CC: @PanAeon @jraygauthier

@jraygauthier
Copy link
Member

@rycee The change seems fine to me. Any reason for the bump feature-wise?

@rycee
Copy link
Member Author

rycee commented Dec 12, 2017

The 8.11.0.4 to 8.11.76.8 bump was mainly because I happened to notice that the new version was available. I don't know if this bump actually adds any major benefit. I did try running the new version, though, and everything seems to work OK.

The 5.5.0.1 in stable needs to be bumped to a later version because the Skype people changed the 5.5.0.1 deb archive in-place to a version that just prints something along the lines of "you are running an old version of skype, please upgrade" 鈽癸笍

@joachifm joachifm mentioned this pull request Dec 14, 2017
Merged
8 tasks
@orivej
Copy link
Contributor

orivej commented Dec 14, 2017 •
edited

The x.y.0.z versions proved to be much more stable than x.y.76.z (even counting the recent rebuild, fixed in #32667), so the reasoning from #31129 (comment) still stands and Skype should not be updated to 8.11.76.8.

@orivej orivej mentioned this pull request Dec 14, 2017
Closed
@orivej
Copy link
Contributor

orivej commented Dec 14, 2017

@Mic92 Sorry, I misremembered your comment.

x.y.0.z are more stable in the sense that they persist upstream for longer, and they are published in the stable dist:
https://repo.skype.com/deb/dists/stable/main/binary-amd64/Packages
https://repo.skype.com/deb/dists/unstable/main/binary-amd64/Packages

@Mic92
Copy link
Member

Mic92 commented Dec 14, 2017

I guess we should not merge this one then.

@rycee
Copy link
Member Author

rycee commented Dec 15, 2017

Fair enough. Thanks for the clarification. I will close this ticket and merge #32684.

@rycee rycee closed this Dec 15, 2017
@rycee rycee deleted the bump/skype branch December 15, 2017 10:53
@rycee rycee mentioned this pull request Dec 15, 2017
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rycee @jraygauthier @orivej @Mic92 @pSub @GrahamcOfBorg