Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mariadb: 10.2.9 -> 10.2.11 #32928

Closed
wants to merge 6 commits into from
Closed

mariadb: 10.2.9 -> 10.2.11 #32928

wants to merge 6 commits into from

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Dec 21, 2017 •
edited

Motivation for this change

Update version. Fix cicle error.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Izorkin Izorkin requested a review from nbp as a code owner December 21, 2017 09:46
@vcunat vcunat mentioned this pull request Dec 21, 2017
Merged
Izorkin
Izorkin commented Dec 22, 2017
View reviewed changes
Copy link
Contributor Author

@Izorkin Izorkin left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

poco: not support MySQL with mysql.connector-c

Izorkin
Izorkin commented Dec 22, 2017
View reviewed changes
Copy link
Contributor Author

@Izorkin Izorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dspam: not build with mariadb

Izorkin
Izorkin commented Dec 22, 2017
View reviewed changes
Copy link
Contributor Author

@Izorkin Izorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

postfix: build error with mysql.connector-c

Izorkin
Izorkin commented Dec 23, 2017
View reviewed changes
Copy link
Contributor Author

@Izorkin Izorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libmysql: no more apps support build with mariadb connector-c

Izorkin
Izorkin commented Dec 23, 2017
View reviewed changes
Copy link
Contributor Author

@Izorkin Izorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amarok: build error with mariadb 10.2

Izorkin
Izorkin commented Dec 23, 2017
View reviewed changes
Copy link
Contributor Author

@Izorkin Izorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qt-4: error build with mariadb connector-c

@Izorkin Izorkin force-pushed the mariadb-10.2 branch 4 times, most recently from 965a1ce to e5c29a7 Compare December 24, 2017 08:19
@globin globin self-assigned this Dec 24, 2017
@globin globin force-pushed the mariadb-10.2 branch 2 times, most recently from 5041992 to 95cd53a Compare December 26, 2017 08:58
@globin
Copy link
Member

globin commented Dec 26, 2017

I've rebased #30546 and (partly) cherry-picked some your changes, can you please rebase on top of that again.

@Izorkin Izorkin force-pushed the mariadb-10.2 branch 4 times, most recently from a81d130 to 051a8f0 Compare December 26, 2017 16:42
@Izorkin Izorkin force-pushed the mariadb-10.2 branch 3 times, most recently from da9a6e9 to 5ee3719 Compare December 26, 2017 20:22
@Izorkin Izorkin force-pushed the mariadb-10.2 branch 2 times, most recently from 0871ea5 to 0ab9c9e Compare December 27, 2017 07:42
ttuegel
ttuegel approved these changes Dec 27, 2017
View reviewed changes
Copy link
Member

@ttuegel ttuegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my part, the changes to Akonadi look fine.

@Izorkin Izorkin force-pushed the mariadb-10.2 branch 2 times, most recently from f9af20d to 142c8bf Compare December 28, 2017 08:43
globin
globin reviewed Dec 28, 2017
View reviewed changes
pkgs/applications/kde/akonadi/default.nix Outdated
''-DNIXPKGS_MYSQL_MYSQLD="${mysql}/bin/mysqld"''
''-DNIXPKGS_MYSQL_MYSQLADMIN="${mysql}/bin/mysqladmin"''
''-DNIXPKGS_MYSQL_MYSQL_INSTALL_DB="${mysql}/bin/mysql_install_db"''
''-DNIXPKGS_MYSQL_MYSQLCHECK="${mysql}/bin/mysqlcheck"''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I won't include this one as it might very well be that we add a bin output to mysql in the future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, rebased

@globin
Copy link
Member

globin commented Dec 28, 2017

This is now all included in the parent PR (although github is having difficulties in displaying this correctly, I've just double-checked the diff), thank you very much for your work on this!

@globin globin closed this Dec 28, 2017
@Izorkin Izorkin deleted the mariadb-10.2 branch December 30, 2017 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@globin globin globin left review comments

@ttuegel ttuegel ttuegel approved these changes

@nbp nbp Awaiting requested review from nbp

@edolstra edolstra Awaiting requested review from edolstra

@edwtjo edwtjo Awaiting requested review from edwtjo

@FRidh FRidh Awaiting requested review from FRidh

@peti peti Awaiting requested review from peti

@rycee rycee Awaiting requested review from rycee

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees

@globin globin

Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Izorkin @globin @ttuegel @GrahamcOfBorg