nrsc5: init at 20171129 #32926

markuskowa · 2017-12-21T08:25:04Z

Motivation for this change

NRSC5 is a comand line tool to receive HD-Radio (digital radio in North America) with
a RTL-SDR radio device.

Things done

Tested with a RTL-SDR USB stick.

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

Mic92 · 2017-12-21T09:38:57Z

pkgs/development/libraries/faad2/faad2-hdc-support.patch

@@ -0,0 +1,644 @@
+From 176e496b2a5461af122e20054079887b0b3d46a8 Mon Sep 17 00:00:00 2001


Is this an upstream patch to the project?

Ah, so this feature is basically derived from this fork? https://github.com/dsvensson/faad2

The patch is from the nrsc5 package itself, which pulls from https://github.com/dsvensson/faad2
during the build process and applies the patch. An alternative solution would be
to add a separate package faad2-hdc, which is build from dsvensson faad2 branch.

grahamc · 2017-12-21T11:51:10Z

pkgs/development/libraries/faad2/default.nix

@@ -12,8 +13,11 @@ stdenv.mkDerivation rec {
    sha256 = "1db37ydb6mxhshbayvirm5vz6j361bjim4nkpwjyhmy4ddfinmhl";
  };

+  patches = [ optional hdcSupport ./faad2-hdc-support.patch ];


This is making an array of three things:

the optional function

the value of hdcSupport

the patch

To make it do what you expect, you'll need:

patches = optional hdcSupport ./faad2-hdc-support.patch;

since optional returns an array:

optional = cond: elem: if cond then [elem] else [];

Thanks for the hint

markuskowa · 2017-12-22T07:41:13Z

Thanks for your feedback. I rewrote the expression. The new solution is now self contained,
less invasive, and does not create an unnecessary cross dependence to the faad2 package.

nrsc5: init at 20171129

8a98924

Mic92 reviewed Dec 21, 2017

View reviewed changes

grahamc reviewed Dec 21, 2017

View reviewed changes

faad2: fixed hdc patch expression

31438fd

GrahamcOfBorg added 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 labels Dec 21, 2017

nrsc5: init at 20171129

deed23d

GrahamcOfBorg added 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 and removed 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 labels Dec 22, 2017

joachifm merged commit 31637d0 into NixOS:master Dec 25, 2017

markuskowa deleted the nrsc5 branch January 19, 2018 07:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

nrsc5: init at 20171129 #32926

nrsc5: init at 20171129 #32926

markuskowa commented Dec 21, 2017

Mic92 Dec 21, 2017

Mic92 Dec 21, 2017

markuskowa Dec 21, 2017

grahamc Dec 21, 2017 •

edited

markuskowa Dec 22, 2017

markuskowa commented Dec 22, 2017 •

edited

		@@ -0,0 +1,644 @@
		From 176e496b2a5461af122e20054079887b0b3d46a8 Mon Sep 17 00:00:00 2001

nrsc5: init at 20171129 #32926

nrsc5: init at 20171129 #32926

Conversation

markuskowa commented Dec 21, 2017

Motivation for this change

Things done

Mic92 Dec 21, 2017

Choose a reason for hiding this comment

Mic92 Dec 21, 2017

Choose a reason for hiding this comment

markuskowa Dec 21, 2017

Choose a reason for hiding this comment

grahamc Dec 21, 2017 • edited

Choose a reason for hiding this comment

markuskowa Dec 22, 2017

Choose a reason for hiding this comment

markuskowa commented Dec 22, 2017 • edited

grahamc Dec 21, 2017 •

edited

markuskowa commented Dec 22, 2017 •

edited