Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

secp256k1: 2016-11-27 -> 2017-12-18 #32919

Merged
merged 1 commit into from Feb 20, 2018
Merged

secp256k1: 2016-11-27 -> 2017-12-18 #32919

merged 1 commit into from Feb 20, 2018

Conversation

asymmetric
Copy link
Contributor

@asymmetric asymmetric commented Dec 21, 2017 •
edited

Motivation for this change

Update to latest. Also, disable benchmarks and tests, since we don't run them. Or should we actually run them?

NOTE: I have no idea about cryptography.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@asymmetric
secp256k1: 2016-11-27 -> 2017-12-18
141688e 
Also, disable benchmarks and tests, since we don't run them.
@joachifm
Copy link
Contributor

cc @chris-martin

@chris-martin
Copy link
Contributor

I have a sad lack of knowledge around the C build environment, but I thought it did run tests? If not it seems like we to ought to.

@asymmetric
Copy link
Contributor Author

I thought you needed to set doCheck = true to run tests, and since we don't, I set those flags, which AFAIU simply install tests, rather than run them.

@joachifm
Copy link
Contributor

@GrahamcOfBorg build secp256k1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

 /nix/store/iifwskzsm4jdapja57w9zasmvz830wg7-coreutils-8.29/bin/install -c -m 644 libsecp256k1.pc '/nix/store/iika6v5yl2s4pwbb1rzxpnpwl8hbm9d0-secp256k1-2017-12-18/lib/pkgconfig'
make[1]: Leaving directory '/build/source'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/iika6v5yl2s4pwbb1rzxpnpwl8hbm9d0-secp256k1-2017-12-18
shrinking /nix/store/iika6v5yl2s4pwbb1rzxpnpwl8hbm9d0-secp256k1-2017-12-18/lib/libsecp256k1.so.0.0.0
strip is /nix/store/adidfx4pa7vmvby0gjqqmiwg2x49yr27-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/iika6v5yl2s4pwbb1rzxpnpwl8hbm9d0-secp256k1-2017-12-18/lib
patching script interpreter paths in /nix/store/iika6v5yl2s4pwbb1rzxpnpwl8hbm9d0-secp256k1-2017-12-18
checking for references to /build in /nix/store/iika6v5yl2s4pwbb1rzxpnpwl8hbm9d0-secp256k1-2017-12-18...
/nix/store/iika6v5yl2s4pwbb1rzxpnpwl8hbm9d0-secp256k1-2017-12-18

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

 /nix/store/5wxjmr5ahlnk2ljkhv5fia1w46qv8ajp-coreutils-8.29/bin/mkdir -p '/nix/store/z8ajlibpbcgvj3clbpx86y950crh9c0s-secp256k1-2017-12-18/include'
 /nix/store/5wxjmr5ahlnk2ljkhv5fia1w46qv8ajp-coreutils-8.29/bin/install -c -m 644 include/secp256k1.h include/secp256k1_recovery.h '/nix/store/z8ajlibpbcgvj3clbpx86y950crh9c0s-secp256k1-2017-12-18/include'
 /nix/store/5wxjmr5ahlnk2ljkhv5fia1w46qv8ajp-coreutils-8.29/bin/mkdir -p '/nix/store/z8ajlibpbcgvj3clbpx86y950crh9c0s-secp256k1-2017-12-18/lib/pkgconfig'
 /nix/store/5wxjmr5ahlnk2ljkhv5fia1w46qv8ajp-coreutils-8.29/bin/install -c -m 644 libsecp256k1.pc '/nix/store/z8ajlibpbcgvj3clbpx86y950crh9c0s-secp256k1-2017-12-18/lib/pkgconfig'
make[1]: Leaving directory '/private/tmp/nix-build-secp256k1-2017-12-18.drv-0/source'
post-installation fixup
strip is /nix/store/v8ifq0hapblpr2z0hx4wvwg02w4aczqy-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/z8ajlibpbcgvj3clbpx86y950crh9c0s-secp256k1-2017-12-18/lib
patching script interpreter paths in /nix/store/z8ajlibpbcgvj3clbpx86y950crh9c0s-secp256k1-2017-12-18
/nix/store/z8ajlibpbcgvj3clbpx86y950crh9c0s-secp256k1-2017-12-18

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

 /nix/store/v9qcwraxmcv4s5v62slzkbwk9182izs9-coreutils-8.29/bin/install -c -m 644 libsecp256k1.pc '/nix/store/3p6rmlfd5ra04j1cvww4ykjwzsrmppkc-secp256k1-2017-12-18/lib/pkgconfig'
make[1]: Leaving directory '/build/source'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/3p6rmlfd5ra04j1cvww4ykjwzsrmppkc-secp256k1-2017-12-18
shrinking /nix/store/3p6rmlfd5ra04j1cvww4ykjwzsrmppkc-secp256k1-2017-12-18/lib/libsecp256k1.so.0.0.0
strip is /nix/store/skd6ix5ipkyhxzq7naylj4digawakl4j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/3p6rmlfd5ra04j1cvww4ykjwzsrmppkc-secp256k1-2017-12-18/lib
patching script interpreter paths in /nix/store/3p6rmlfd5ra04j1cvww4ykjwzsrmppkc-secp256k1-2017-12-18
checking for references to /build in /nix/store/3p6rmlfd5ra04j1cvww4ykjwzsrmppkc-secp256k1-2017-12-18...
/nix/store/3p6rmlfd5ra04j1cvww4ykjwzsrmppkc-secp256k1-2017-12-18

@joachifm joachifm merged commit b60ef32 into NixOS:master Feb 20, 2018
@asymmetric asymmetric deleted the asymmetric/secp256k1 branch February 20, 2018 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@asymmetric @joachifm @chris-martin @GrahamcOfBorg