wakatime: Explicit checkPhase
#32935
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The write errors can be fixed by adding |
|
Ah nice 😎 But unfortunately the tests run and fail with assertion errors :( |
markus1189
force-pushed
the
wakatime-fix
branch
from
05ddf1f
to
ea814e9
Compare
FRidh
requested changes
Dec 21, 2017
pkgs/tools/misc/wakatime/default.nix
Outdated
| @@ -1,7 +1,8 @@ | |||
| { stdenv, buildPythonApplication, fetchFromGitHub }: | |||
|
|
|||
| buildPythonApplication rec { | |||
| name = "wakatime-${version}"; | |||
| baseName = "wakatime"; | |||
pkgs/tools/misc/wakatime/default.nix
Outdated
| @@ -1,7 +1,8 @@ | |||
| { stdenv, buildPythonApplication, fetchFromGitHub }: | |||
|
|
|||
| buildPythonApplication rec { | |||
| name = "wakatime-${version}"; | |||
| baseName = "wakatime"; | |||
| name = "${baseName}-${version}"; | |||
There was a problem hiding this comment.
Does it default to ${pname}-${version}?
The actual tests write to the filesystem and lead to errors Related NixOS#32244
markus1189
force-pushed
the
wakatime-fix
branch
from
ea814e9
to
4be7311
Compare
And they're not fixable? |
|
I don't know, I did not test :D |
|
Tests were disabled in #33917 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual tests write to the filesystem and lead to errors, so I replaced them with a different sanity check for the version
Related #32244