Makefile: allow passing through LDFLAGS to final link phase #5423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The best tool for seeing what crystal is doing in a release build is either I'm not as sure about the |
LDFLAGS allows distributions to pass their specific flags.
LDFLAGS is a typical variable along with CC/CXX/AR commonly
seen in autotools projects.
For example Gentoo uses:
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu"
That way all the final binaries include GNU-style symbol hashing
and omit unused dynamic libraries (llvm has a lot of thse).
It's also handy to pass things like "-Wl,-z,now" to force early
symbol binding.
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
|
Aha! I'll try progress again. I think I wanted Also expanded use case of |
RX14
approved these changes
Dec 21, 2017
asterite
approved these changes
Jan 2, 2018
lukeasrodgers
pushed a commit
to lukeasrodgers/crystal
that referenced
this pull request
Jan 7, 2018
…lang#5423) LDFLAGS allows distributions to pass their specific flags. LDFLAGS is a typical variable along with CC/CXX/AR commonly seen in autotools projects. For example Gentoo uses: LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu" That way all the final binaries include GNU-style symbol hashing and omit unused dynamic libraries (llvm has a lot of thse). It's also handy to pass things like "-Wl,-z,now" to force early symbol binding. Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While at it allow verbose builds: handy to see what crystal
is doing when doing release builds for 20 minutes.
Signed-off-by: Sergei Trofimovich slyfox@gentoo.org