Fix String#gsub and #tr ASCII-only optimisations #5498
Closed
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chastell
force-pushed
the
ASCII_replacements
branch
2 times, most recently
from
7fa148a to
c1512fa
Compare
chastell
force-pushed
the
ASCII_replacements
branch
from
c1512fa to
9d69ea0
Compare
|
I believe #5350 has a more general fix for this. |
|
Ah, right, apologies, I totally missed that PR! Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b14d8c7 introduced some
String#gsuband#troptimisations for ASCII-only replacements. Unfortunately, to the best of my understading, for those optimisations to work theStringitself has to be ASCII-only – with the current implementationString#gsub_ascii_charturns"foo bär".tr(" ", "-")into"foo-bä\u0000"